ci(release): tighten release workflow hygiene#463
Merged
Conversation
Signed-off-by: Roel de Cort <roel.decort@adfinis.com>
Signed-off-by: Roel de Cort <roel.decort@adfinis.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
app-idinputs toclient-idsecretshack/ci/verify-post-release.shfor post-release tag, asset, signature, chart, and release-please cleanup checksRelated Issues
None.
Type of Change
Risk and Compatibility
No API, CRD, Helm, RBAC, security, or upgrade compatibility impact. Release automation now requires
OPENBAO_OPERATOR_RELEASE_PR_CLIENT_IDandOPENBAO_OPERATOR_RELEASE_TAG_CLIENT_ID; the matching secrets have been added before this PR.Verification
bash -n hack/ci/verify-post-release.shhack/ci/verify-post-release.sh --helpgo run github.com/rhysd/actionlint/cmd/actionlint@v1.7.11 .github/workflows/release-please.yml .github/workflows/release-tag.yml .github/workflows/prepare-release-as-pr.ymlmake docs-buildgit diff --checkmake lint-ciReviewer Notes
The full post-release helper is intended to run after a release has published. I validated syntax/help locally; full execution would currently fail by design while #395 and
release-please--branches--mainare still active.Checklist